Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate swapVCow code from claim #365

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Separate swapVCow code from claim #365

merged 2 commits into from
Apr 5, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Apr 4, 2022 •
edited
Loading

Summary

Part of the #349

  • split the swap vCow->cow code from the claim code so in the next step we can remove the claim code or it can stay but it doesn't affect the swap functionality
  • add MOO sound when swap vCow->cow transaction is mined
  • redirect /claim -> /profile

To test

  • we make sure that the swap vCow->cow works as usual

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@nenadV91 nenadV91 changed the base branch from develop to release/1.13 April 4, 2022 15:18
@nenadV91 nenadV91 force-pushed the 2639/hide-claiming-page branch from 5164694 to efe08e5 Compare April 4, 2022 15:20
@nenadV91 nenadV91 requested review from a team April 4, 2022 15:25
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

anxolin
anxolin approved these changes Apr 4, 2022
View reviewed changes
src/custom/state/swapVCow/hooks.ts Outdated Show resolved Hide resolved
@nenadV91 nenadV91 merged commit c2271be into release/1.13 Apr 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
@elena-zh
Copy link

elena-zh commented Apr 5, 2022

Changes LGTM besides the case when MOO sound is played when a transaction is failed.
I reported it in #370

@nenadV91 nenadV91 deleted the 2639/hide-claiming-page branch June 14, 2022 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nenadV91 @elena-zh @anxolin